The weekly IRC meeting has been moved back one hour to 20:00 UTC. Still on Wednesdays. As always, check the sidebar for that info.
Updates from Mark Jaquith Toggle Comment Threads | Keyboard Shortcuts
-
Mark Jaquith
-
Mark Jaquith
We’re really close
We’re so close to beta, I can taste it. For today’s meeting, think of anything outstanding that is still a beta blocker and then let’s talk about how we can get it sorted today. We’re going to keep at it until it’s ready. When? When it’s ready. But I’m hoping in the next 24 hours.
-
Shapeshifter 3
-
Aaron D. Campbell
Look into the add_editor_style() function and the editor-style.css theme file. Then you can use CSS to style the editor content however you want.
-
Shapeshifter 3
Thank you. I was thinking that it might be easier for newbies to have the Visual Editor’s background somehow automatically switch from dark to light depending on what contrast the user needs. Just a thought.
-
Aaron D. Campbell
I think that if you’re changing the foreground color with CSS, it seems reasonable to expect that you’d be able to change the bg color as well. I don’t particularly see the need for this one.
-
-
-
Chuck Reynolds
like -
Shapeshifter 3
I’m on a learning curve. Where on the WordPress.org site can I fing a current running list of all 3rd party plugins & scripts that become part of the WordPress Core. I notice reading some of core.trac.timeline that certain things such as Backbone.js, Minimum PHP and others are frequently updated. Where is the list of all of those components kept?
-
Kim Parsell
A good place to start is the list of External Libraries at the bottom of the Credits page in your WordPress install.
-
Shapeshifter 3
Thank you, Kim….I’ll start looking there.
-
Shapeshifter 3
Hey, Kim. This is the type of page I was looking for, except completely up-to-date: http://make.wordpress.org/core/2012/08/29/external-libraries-in-3-5/
-
-
Alex
I guess this is what you are looking for? http://tr.im/428tg
-
Shapeshifter 3
That’s even better yet…….Super Thanks, Alex !
-
Drew Jaynes (DrewAPicture)
It’s worth noting that this may not be updated yet in terms of 3.6. It’ll be covered in the Codex Sprint closer to the final release.
-
-
-
-
-
Mark Jaquith
The Road to 3.6 Beta 1
our original schedule had us hitting beta 1 today, March 13th. We’re not quite there. Beta should mean that we’re feature complete, and we’re not. We could do what we’ve done in the past, and declare a beta, while continuing to do feature work, but that just devalues the meaning of “beta”. I want people in the WordPress ecosystem to trust that when we say “beta”, that means we’re feature complete and that they should start seriously testing their themes and plugins against trunk for issues. If we continue with feature development during the beta period, that will just shove back everyone’s testing to the RC period, which will translate to more issues going unnoticed and tarnishing the release.
Consequently, I’m pushing the beta date back two weeks, to March 27th, and the release back one week to April 29th. If our beta period is actually a beta period (to work on bugs, Â not features), three weeks should be plenty of time. Ditto for the two-week RC period, for major bugs. We’ve needed longer periods in the past because we’ve been doing major feature development through the beta period and into the RC period, which, as mentioned above, I don’t want to do again.
Here is the major new-feature or new-feature-related stuff that needs to be settled and land in core (if they are going in at all) in the next two weeks (front-loaded as much as possible). Let’s redouble our efforts and get this sorted so we can get a beta out the door.
Revisions
Post Format UI
Twenty Thirteen
Post locking
Nav Menus
-
Peter Westwood
The revisions UI Ticket is #23497
-
Mark Jaquith
Got it.
-
-
Myatu
Sigh. I only have three requests for the devs: Comments, comments and comments. There’s a lack of proper developer documentation (read: the outdated Codex). But resorting to the actual source code/phpdoc is of no help either, as there’s a distinct lack of comments (particularly the additions added with 3.5 such as the new Media Library Javascript code). This is compounded by the fact there’s no rhyme or reason to some of the coding styles used – its getting uglier by the day, and I’m wondering if that has to do with missed deadlines (and thus devs feel pressured to make haste). Maybe it’s just me… But its starting to take the fun out of things.
-
Mark Jaquith
I agree. And yes, the media stuff (as wonderful as it is in execution) is too much of a black box. Just like we have people who update our help tabs and our PHPDocs, there should be people who work on improving code commenting, formatting, and readability. Would be a good task for someone who is new to core, as their confusion about unclear sections would be genuine and not simulated, as it might be for someone who already knows what the code does.
-
-
adamsilverstein
also on revisions: #22289 (Filter to override WP_POST_REVISIONS)
-
Drew Jaynes (DrewAPicture)
-
Mark Jaquith
Yep, done.
-
-
-
Mark Jaquith
Dropping Editorial Flow
I’ve decided to drop the Editorial Flow feature from the 3.6 roster. A few things happened. We looked into what the main feature (“forking” a published post and allowing it to be edited then reintegrated) would involve, and found that there were some really fundamental hurdles that were unlikely to be resolved in the time given. A lot of time was spent on the planning stage, and we just kept surfacing more questions. Moreover, because the hurdles were so low-level, they would have required a significant amount of time from a core lead like me, @nacin, or @ryan — time that we just didn’t have to give this cycle due to other responsibilities. What that left was #12706 — a somewhat related ticket with a long-running monster patch. This similarly needed (and still needs) a core lead to dedicate a lot of time to planning, reviewing, and committing it. That might happen, or might not. It didn’t seem fair to keep @danielbachhuber and @kovshenin responsible for something that might or might not make it, subject to other people’s availability.
Though disappointing, this effort wasn’t wasted. We learned a lot about the challenges involved, and we’re better positioned to tackle it in the future with more advance planning and a better understanding of the core team resources that need time dedicated to it.
-
Alison Foxall
Understandable. I had been loosely following what was going on and it just seemed like a huge task to undertake. Looking forward to getting more involved in the future.
-
Marko Heijnen
I guess for 12706 it makes sense to develop it on Github. Like what happend with WP_Image_Editor. You still get an monster patch in the end but the changes can be better maintained. If I would make a change on the code now literally no one would find out precisely what I changed.
-
Nikolay Bachiyski
This or we actually start using branches.
-
-
scribu
Is there some place where the lessons learned from the planning stage are summarized?
At the very least, links to some IRC logs would be good.
-
Robert Lilly
Sorry to hear this won’t make it into the next release, but glad to realize that the issues involved are being thought through and that this will be addressed in the near future. I think this is a feature that is really needed whenever there is more than one person involved in creating/editing/maintaining posts.
In my fantasy I’m imagining something like the Review feature of Microsoft Word, specifically the Track Changes and Add Comments functions.
-
-
Mark Jaquith
A first draft of the Twenty Thirteen theme is now in core, for your inspection and iteration. See: r23452
A demo site is available for you to browse.
@matt set the goals for this theme: a focus on blogging, and great support for post formats (which are getting attention on the backend in 3.6 as well). Under Matt’s guidance, @joen explored the artistic possibilities and was joined by @obenland and @lancewillett in bringing it to fruition.
What you’ll notice first is the colors. Way more use of color than a bundled WordPress theme has had before. Each post format has its own color, so each is distinct, yet they are all complimentary. The bold colors encourage authors to try out all the different formats. This color extends the full width of the window, which breaks your blog up into a lush, segmented timeline. This effect is even more pronounced on mobile browsers, where the screen can be dominated by one or two posts at a time, in all of their chromatic fullness.
On closer inspection, you’ll notice details, like the font-based icons (“Genericons”, by @joen) that scale up to any resolution or zoom level and can be easily recolored using CSS.
You may notice some playful details, like the size-offset pagination arrows:
Or the 404 page (which I’ll leave to you to find).
One of the goals of having a new theme every year was to give ourself room to experiment. That hasn’t really happened. We’ve been far too conservative, trying to make themes that work reasonably well for everyone, but don’t push boundaries too much. That changes with Twenty Thirteen. It’s hard not to have a strong feeling about the theme, one way or another. It defies you to give it a shrug or a kurt nod. Some of you will hate it. And that’s okay. We’ll still be shipping Twenty Twelve, which is an excellent base theme and a canvas on which you can build anything from a blog to a static content site. But with Twenty Thirteen we’re taking a bold stance: this theme was meant for blogging, and it’s not a blank canvas. It comes pre-marinated with playfulness and warmth and opinions.
Twenty Thirteen really prefers a single column layout. Widgets live best in the footer, where jQuery Masonry bricks them together (but it supports a sidebar, if you really insist). Header images have a fixed width and height, and will be cropped at smaller resolutions, so the best choice is an artistic header where not 100% needs to be shown all the time (it ships with three).
Now that we have a first draft of Twenty Thirteen in core, it’s time to start iterating and sanding off some of the rough edges. Accessibility is still important, even when making bold artistic statements, and I’d be surprised if we didn’t have work to do there. We’ll need testing on lots of different browsers and platforms, and with lots of different plugins. @helen‘s Post Format UI team will need to give feedback on upgrading Twenty Thirteen to use the new post format API functions that are available.
@lancewillett and @obenland will be holding Twenty Thirteen office hours on Tuesdays and Thursdays at 1700 UTC. Interested parties should make an effort to attend and help us get this beauty ready for beta!
-
Amy Hendrix (sabreuse)
First impression: WOW
-
Michael Beckwith
Holy color!
-
Alison Foxall
Nice Mark!
First thing I notice is that although the search bar sticks to the top with the Twenty Thirteen branding while you scroll, the main navigation is not up there with it on both large desktop screens and small device screens. Was there a reason for this or can this be changed by the user? And of course I\’m wondering if the user will be able to change those colors for each post format.
-
Mark Jaquith
It’s a known issue, and something I’d like rectified. The dropdown menu that you get on small screens would be great up there. And colors could be overridden by a child theme — probably a lot of option overload if we exposed that.
-
-
Mel Choyce
WOW, instant love! The colors are bold but harmonious, the type is GREAT, and it’s got such a fabulous funky retro futurist feel. Thumbs up!
-
Emil Uzelac
Pretty good for the first draft!
-
Xavier Borderie
Wow indeed! I too was getting a feeling that the “clear white” theme spirit could feel overplayed if 2013 had it. I for one am very glad that the team is making such a bold move in a creative direction. I trust there will be enough theme option and color schemes so that users can make it their own in a few clicks.
Great work!
-
aradams
Love the colors, love the flow. Nice to see creativity unleashed on the default theme!
-
Ipstenu (Mika Epstein)
Nice! Just … Amazingly nice. I’m gonna have to find a site to use that on. Maybe my own!
-
Marcel van der Horst
Can’t wait to try it out..
-
BrentLeavitt
I find that to be just delightful!
-
Aaron D. Campbell
So excited to have this in. It really is great!
-
Tony Scott
http://genericons.com/ seems to be behind a WP.com password.
-
Aaron D. Campbell
The genericon site isn’t up yet. I think you can see the icons here for now: http://moc.co/a8c/genericons/example.html
-
Tony Scott
Yep – got it!
Many thanks Aaron.
-
JonManness
@Aaron, the theme and genericons look great! Are there plans to create icons for SoundCloud, IMDb, Vimeo, and YouTube?
-
designsimply
Vimeo and and a minimal YouTube icon have been added already! We might be able to add SoundCloud and IMDb in the future at some point too. I expect the font to grow.
-
-
-
designsimply
You guys probably have noticed by now that http://genericons.com/ is live. I just added a post to themeshaper.com about them too, if you’re interested.
http://themeshaper.com/2013/02/27/genericons-icon-font/I love icon fonts!
-
-
Chuck Reynolds
Looking forward to the post format specific layouts and metadata.
Would be nice if the video, once ‘fetched’, would autopopulate the title. -
@mercime
Very Nice! Shades of BuddyPress
-
trishasalas
…beautiful, you’ve managed to stick with the mimimal yet spice it up with jazzy colors. Instant LOVE <3
-
Austin Passy
The theme demo looks great. Like the direction it heading in.
-
Jose Castaneda
Looking forward to testing the formats. Now to get home and uptade core.
-
Eduardo Zulian
Just finished testing Twenty Thirteen with the new post formats scheme. Sweet. : )
-
Lori Berkowitz
Looks great! Also nice to see some post formats love
-
Edward Caissie
Except for the header trick … sorry, it’s just not doing anything for me.
-
Mark Jaquith
What if it had menu access like the mobile menu?
-
-
Anthony Hortin
It’s lookin’ great so far! Well done to all involved!
-
Matt Mullenweg
It’s counterintuitive because this is a visually much more aesthetically opinionated base than we’ve had probably since Kubrick, but I think we’ll see a lot more customization and variations on Twenty Thirteen than Eleven or Twelve. It’s a delightful canvas to play on.
-
Jose Castaneda
I agree, it does seem like it can be a great starting point for future themes and child themes.
-
Daniel
While the CSS is pretty opinionated, as you call it, the theme’s markup is clean and streamlined. I believe this is a canvas just as good as any other core bundled theme.
-
Samuel Wood (Otto)
Well, in that spirit, I made a blue version.
-
-
Justin Sternberg
Nice work all around! I couldn’t help myself: http://jtsternberg.com/
-
Sovit - (Theme Horse)
This one will be the great example to show that without choosing white color can also make clean and beautiful theme. Love the way designer play the colors.
Thanks to all contributors. Its really Fantastic ! Can’t wait to see it out in my themes directory. -
Noel Tock
Love the new direction, looking versatile and fluid, +1
-
Ryan Hellyer
And here I was thinking that WordPress default themes need to be bland and white.
-
Petya Raykovska
Wow. Bold move, I love it.
I’d make the main navigation sticky though, together with the search bar and the site name.
And it would be great to have some color palettes to choose from as visually color is the first thing you experience with this theme.
-
emzo
Default WordPress themes have always been great, but they’ve needed to be versatile and cater to the majority, and in doing so have had to be more conservative. This puts the fun back into WordPress, and definitely brings a smile to my face. I do agree that the collapsed mobile menu should be placed in the fixed header when scrolling though.
-
Luc De Brouwer
This. Looks. Awesome.
-
lonchbox
Excellent work! I love the post formats styles
-
sourceforge
there was a theme in tumblr directory by peter vidani, which used the colors for post types!
-
Monika
it looks like Windows8
colorful and dizzying. -
mindctrl
Nice and different direction. With this new bold approach, I’d like to see the base font size increased a bit more. Chrome is telling me it’s 16px, and with Source Sans Pro 16px looks more like 14px. It looks good and is easier to read at 18 or even 20px.
-
Aaron Aiken
Absolutely beautiful. Good work!
-
Arnan de Gans
Sponsored by Ubuntu I see…
-
Nashwan Doaqan
It’s really a beautiful theme , but I don’t think It’s good to be a default theme ,It’s too colourful … Yes it’s different direction but many of WP users like the default themes because they are simple and have a less colours , I was thinking if you can make the colours system is optional in the theme control panel ….
As I am seeing now , Its seems to be hard to use it as a framework , the default theme should be simple , clean , easy to customize and express WordPress main features !
-
Aaron D. Campbell
Twenty Twelve will still be packaged with WordPress too. I do however think this theme will actually be pretty easy to extend.
-
Emil Uzelac
This is actually going to be a perfect default Theme and honestly, very easy to customize as well.
Colors are post formats and they can be changed or removed
-
-
Daniel
Is there a reason why the fixed navbar replaces the navigation menu with the site title? Doesn’t that pretty much defeat the purpose of the fixed navbar to provide better accessibility to the site’s navigation? Why would I need a static bar with just a link to the front page?
-
David Radovanovic
ooooooooo, ahhhhhh – very awesome indeed! The long scrolling homepage, ever-adaptive elements, and I’m sure much more will be realized with a test drive. Thanks!! BTW – why the persistent header with banner on all pages? Am I alone in wondering why is the banner needed on pages other the homepage?
-
Jean-Francois Arseneault
Surprised to still see ‘Links’ in there as a post type…
-
shazdeh
Love at first sight.
-
Zulfikar Nore
Bold And Beautiful! A total change in direction from previous “Default” themes – this will make an awesome parent theme for developers to tinker with.
Would like to chime in on the menu though….the sticky menu “bar” minus the menu is not doing it for me – I would like to see the menus as I scroll the page instead of a blank “bar”.
Further more, since its bold in terms of color scheme – I would like to see the options to adjust the various sections incorporated in the Customizer’s Color section and not having to rely on changing them via child themes. As it is the child theme option would work for developer but not for the novice end user.
But all in all, I’m totally loving what I see so far – now its time to go break it apart and see what I can conjure up
-
bjornsennbrink
What is up with the breaking of words in titles and in text? It was there in Twenty Twelve and is still around. Any insight on the word-breaking thingy would be great
-
alvarogois
Strange unanimity… I’m a guy who likes color and bold, though I’m more for minimal. I don’t understand this theme and can’t picture it as a default WordPress theme. Maybe the focus here is on blogs, I get it, and giving the author a panoplia of customization options. I get it too. Nevertheless, I fail to realise how one goes from twentytwelve to this twentythirteen. Sure, it’s a cut, but I don’t see it as a step forward, something new, more like something else.
(I could be wrong, though… me and Nashwan Doaqan up there…)
-
Marco Raaphorst
cool, love it!
-
rilwis
Amazing theme. I like it and have a good feeling when I see it at first. It’s great when you can push the boundaries so far. It’s time to show people that WordPress is easy to customize.
-
Brad Dalton
Its like it or not based on my readers feedback. Personally i love it but also know you guys could seriously blow the socks off any premium theme out there. Built in hooks and conditional tags is where its headed i think. WordPress theme users are smarter now and want more. They understand the basics of coding. Extend further.
-
tomjanski
The bold colors and bold theme. Bravo. It’s going to be a good one.
-
Shea Bunge
Wow… really, really good. It”d be nice to get the default theme out early this year. (I;ve always thought that the annual themes should be released at the start of the year, not the end
-
lisafirke
Gorgeous and playful. Bravo!
-
Tatiane Pires
Great!
I can’t wait to make a new theme for my blog based on Twentythirteen. -
suzybyrnes
love the full width. Agree with comments about fixed nav bar. Look forward to seeing what people do with it. Thanks v much.
-
bru.scopelliti
What I have seen is very promising. Can’t wait the release
-
-
Mark Jaquith
Feature Team Updates and Office Hours
The WordPress 3.6 feature teams should be updating here on make/core twice a week, on the following schedule. List any major developments, summarize any notable IRC conversations that happened, call for help where coding, testing, discussion is needed, etc. They don’t need to be long, unless a lot of stuff happened. The idea is that people who aren’t in IRC and Trac every day can still stay up to date on features and jump in when they can. And it will keep the teams aware of their progress (or lack thereof) on a more regular basis.
Monday and Thursday
- Autosave/Post Locking
- Nav Menus
- Post Format UI
Tuesday and Friday
- Editorial Flow
- Core Maintenance and Architecture
- Revisions
Next, while many features are still being actively planned, the feature teams should hold IRC office hours where more realtime discussion can take place to get the features scoped and planned a little better. Feature teams should announce these hours here on make/core (can be part of their twice-weekly updates).
-
Mark Jaquith
Agenda for the weekly dev chat:
1. Feature team updates
2. Set up schedule for more frequent feature team updates
3. Unstick anyone who is stuck
4. Rallying call for Ryan’s code maint ticket list-
Schwarttzy
Hi, I’m new to this whole WordPress Core thing and would like to add to the core with an idea I have to help responsive web designers with featured images. Basically, add an option for setting an aspect ratio, instead of defining some fixed width and height. How do I get started?
-
Amy Hendrix (sabreuse)
Hi Schwarttzy, and welcome! If you’re interested in contributing, you should start with the Core Contributor Handbook, which has a lot of information about the process and the tools we use:
http://make.wordpress.org/core/handbook/
It’s also incredibly useful to drop in on a few of the weekly dev chats in IRC — even though a lot of what happens there is updates on what different teams are doing, it’ll give you a good idea of what’s going on as well as the whole workflow. You’re also welcome to ask in #wordpress-dev if you need more help getting started; there’s usually someone around outside of meeting times.
As for responsive images, there’s an existing ticket to make heights and widths filterable, although it hasn’t seen any action in a few months: you might want to start with getting familiar with the discussion and patches that have already happened in that effort. Check out #14110
-
-
-
Mark Jaquith
WordPress 3.6: Code Maintenance and Architecture
Like with any release, much more is going on during the 3.6 cycle than just the user-facing items on our agenda. We’d like to hit the following code maintenance and architecture items as well. If your interested or have thoughts, speak up or jump on the tickets! Some of these really should happen early, and they’re pretty much all going to need unit tests.
Use PDO for MySQL queries
#21663 — The
mysql_*functions in PHP are deprecated, so to get ready for future versions of PHP, we need to start routing queries alternatively for installs that support it.Caching and Misc DB Tasks
No ticket for this? — Use magic methods to cleanup blogid and siteid in wpdb. These should fetch the canonical versions elsewhere. Also, support blog_id and site_id for consistency.
#23167 and #23173 — Make our object caching more intelligent. One query per cache key. Stored IDs instead of objects where possible.
#22174 and #20875 — Introduce and use wp_cache_get_multi(). Maybe. A bonus, if there’s time.
#21760 — get_term_by() calls are not cached.
#21401 — Load packaged object cache when advanced-cache.php and object-cache.php don’t implement wp_cache_init().
#22661 — Allow object caches to degrade gracefully.
Slashing Sanity
#21767 — Remove stripslashes from API functions.
#18322 — The Road to Magic Quotes Sanity.
#22325 — Abstract GPCS away from the superglobals (maybe not, depending on #21767).
#22023 — Remove UNIQUE for slug in wp_terms. Prep for future taxonomy architecture changes.
Misc Performance
#22301 — Performance problem with Recent Comments widget.
Earlier Discussion
IRC Logs from discussion of some of these items.
-
Ryan McCue
I’m happy to lead efforts on #22325 (GPCS abstraction), and work on #21767 (removing stripslashes) and #21663 (PDO). I think a high-level discussion on what we want out of the GPCS abstraction would be nice; @nacin said he was going to make a P2 post about it, but I don’t think he ever got to it with his busy schedule.
-
-
Mark Jaquith
Git Mirror History Breakage
A few years ago, I started publishing a mirror of WordPress on GitHub. It was subsequently promoted to WordPress/WordPress. What I neglected to do, however, was provide an appropriate
authors.txtfile, until recently. That means that earlier commits are attributed to dummy e-mail addresses and as such cannot be associated with user accounts on GitHub. Considering the recent introduction of contributions on GitHub, this seems a shame. Also, if we were to move to Git in the future, we would probably want our official mirror to have the best possible data.Proposed
That we re-run the
git-svnimport with a properauthors.txtfile.Upsides
We’ll have a proper Git mirror with good and consistent author data, that we can, if desired, use for a future migration to Git. Commits will be properly attributed in GitHub.
Downsides
This will break Git history. If you have a Git checkout of WordPress, either standalone or in a submodule, that’ll mean that you’ll have to rebase your master branch off of
origin(or even better, blow the whole thing away and re-clone).So: thoughts? Would this ruin your day?
-
Gustavo Bordoni
If this means that WordPress is taking any sort of steps towards using Git as a solution for code versioning I’m all for it!
-
Mark Jaquith
I’ll just add that we can’t commit to anything at this stage.
-
Japh
I see what you did there.
-
John Saddington
LOL. Seriously. Totally sucks to lose that historical contri trail…
-
-
Gustavo Bordoni
I know, just expressing my feeling about git. haha
-
Claudio Sanches
I also would be happy to use GIT to contribute.
I certainly send several Pull Requests
-
Andrew Nacin
You can already use Git to contribute. We operate using patches (and would probably continue to do so even if we switched).
-
Scott Taylor
are Unit Tests on Git yet?
-
-
-
-
-
Scott Taylor
DO IT! And document the ideal way to mirror with authors.txt after, please. I mirrored a bunch of repos and forget to do the authors part and I haven’t collected the energy to start over yet.
-
Bryan Petty
Authors file is simple: one author per line: “loginname = Joe User “.
Run this to generate your initial authors file (from the root of your SVN checkout):
$ svn log -q | awk -F ‘|’ ‘/^r/ {sub(“^ “, “”, $2); sub(” $”, “”, $2); print $2″ = “$2″ “}’ | sort -u > authors.txtFill in the file with real names and email addresses.
I use a modified version of Mark’s script to mirror a ton of repos myself:
https://gist.github.com/3061041It’s mostly self-explanatory, see forked gist for Mark’s version.
-
Mark Jaquith
Another thing I’d do is contact everyone in that file and get them to doublecheck that we have an e-mail address that they’re likely to control for life. Probably best to use e-mail at a personal domain, if they have one, instead of Gmail or a company e-mail address that they might lose in the future.
-
-
-
Daryl Koopersmith
I think an accurate repository is worth the temporary breakage.
-
Japh
+1
-
Peter Westwood
+∞
-
Boone Gorges
+1
-
Tom Willmot
+1
-
Aaron D. Campbell
+1
-
mojowill
+1
-
Till
+1
-
Piet
+1
-
-
Ryan McCue
+1, I’d say we do it.
What’d be really cool is if we can get the props parsed so that git lists the commit author as whoever was prop’d, and the committer as the person who actually committed it. AFAIK, that’s not possible without a complicated script though.
-
Bryan Petty
That would be cool, but I really can’t even think of any way to do something like this with the current repo as is without amending commits after the initial clone, which would be extremely resource intensive and could take weeks to do. Given that and the work involved with integrating the same process into the mirror updates for future commits as well, I would just say forget it.
-
Bryan Petty
Actually, come to think about it, git-filter-branch might be able to handle this efficiently.
-
Mark Jaquith
git-filter-branchindeed could do it. It probably wouldn’t be too bad.
-
-
-
Mark Jaquith
Interesting idea. But wouldn’t be able to handle issues with multiple props recipients. But we could give it to the first person or just in this case give it to the committer.
-
Ryan McCue
Multiple props authors mean that it’s ambiguous who actually created the patch, so the committer should be assigned credit lest we accidentally attribute it to the wrong person.
(Also, we’d probably want to make sure that we fix up typos. `rmmcue` for example.
-
-
Peter Westwood
While parsing props like this would be cool I don’t think it would accurately reflect the way our process has worked and I would much rather put effort into collecting the props to commit data into a format we can integrate into the WP.org profiles more easily.
I started on this a while back but haven’t finished yet, what I’m mostly missing is an 100% accurate props extraction method.
-
Ryan McCue
At the moment, there’s basically two forms of commits with props: 1) the committer is merely committing a patch that was on a ticket (this is where we’d want to split author/committer); and 2) the committer is writing the patch with inspiration from someone (we’d want author = committer in this case).
As far as I’ve seen, 1 seems to be the much more common case, but 2 is fairly common too. It could be a problem. (Regarding effort, it’s relatively simple using
git filter-branch, so that shouldn’t be much of an issue.)
-
-
-
Michael Beckwith
I do all my pulling of WP from the svn repo anyway, but I keep an eye on some development via github. No harm for my stuff
-
topdown
I think that authors/contributors should be recognized when ever possible…
+1 I say fix it. -
Mike Schinkel
Got for it!
-
Bryan Petty
I think you’re already aware that I actually use my own clone of the WP repo partly for this reason, but also because it’s nice having branch and tag names that are exactly the same as the branch and tag names in SVN. It would be nice if those were fixed up as well if you do this.
-
Mark Jaquith
Yeah, if we’re doing this, we should take the time to iron out all other niggling issues. Would love to have your input on that. My issue with branch names is that it create ambiguous references. So if you go to checkout “3.5″ it will check out the 3.5 branch. In order to check out the 3.5 tag, you need to do
git checkout tags/3.5. Not the end of the world. Might be worth it to get everything cleaned up.Hey, maybe we can just rebase me and retroactively teach me all this Git and Git-SVN subtleties!
Just don’t push me, man.-
Ryan McCue
The way I do it for SimplePie is to name the branches spelled out (ala WP.org release notice slugs), such as
one-dot-two. That avoids the ambiguity there. However, that’s probably a pain for WP.Another option I’ve seen which are popular: rename all tags (or all branches) to
vX.Xso that any one starting withvis the tag (or branch) and without is the opposite.-
Boone Gorges
For my own stuff I do something like this. `3.5` is the tag, and `3.5.x` is the branch. I think Drupal does it this way.
-
Aaron D. Campbell
Or enforce 3 digits for all tags and 2 for all branches, so 3.5 is a branch and 3.5.0 is the first 3.5.x tag
-
-
Bryan Petty
Mark does already do this, which is why the branches are named
#.#-branch.Anyway, git does assume you wanted the branch instead of the tag, but that’s almost always the case for me anyway. I almost never checkout the tags, and I don’t think anyone else does either (definitely not with SVN either). In the 5 months or so that I’ve had my mirror running, this has never gotten in my way once or annoyed me in any way.
-
-
Bryan Petty
One other issue that’s really minor is that there’s still an
iisbranch in SVN that didn’t make it into your mirror that probably should.
-
-
-
sourceforge
it would be good, i have been asking /systems guys to install git as revision control, but it seemed only someone in some driver’s seat could ask for stuff there! git is fast, no problem if it breaks for a while! thanks for this! full ahead flank
-
Ozh
I think it’s possible to modify afterwards the author of each commit, so you don’t break the whole history
https://gist.github.com/4032945-
Ryan McCue
That will change the commit hashes, since the author/committer is stored as part of the commit object (which is used to create the hashes). There’s no way (by design) to change these after the fact without doing this.
-
Ryan McCue
(Also, forgot to note: even if this only changed one commit, this would cascade down through all subsequent commits, since the parent’s hash is also included in the commit object)
-
-
aristath
I think it would be a great step forward. Drupal also used to be in SVN and switched to Git a couple of years ago. It was entitled “the great git migration” and took almost a year to design, layout and implement the whole process but it was worth it. Using Git has many advantages! I believe that breaking the history is worth it in the long run.
Sure it might be a bit inconvenient at first, but I believe that it could really give a new boost to WordPress development.-
aristath
correction… Drupal used to be CVS, not SVN. But the principal is the same…
-
Ryan McCue
To clarify: this isn’t about moving WordPress to Git, this is about fixing up the Git mirror of the SVN repo. This is a step we’d need to take if it was decided to move WP to Git, but it’s not the main goal.
-
-
Remkus de Vries
Git ‘er done I say. Having to do a rebase / clone is no biggy at this stage.
-
Baki Goxhaj
Re-cloning WordPress is not a big deal and adding appropriate author information is the way to go toward the future, thus I think it should be done — the sooner the better.
-
Tareq Hasan
Surely go for it. A step towards SVN to Git.
-
Abhishek Ghosh
Git is always a better option but needs carefulness on individual basis. Many options for an user is to download. The developer is getting the option to create a better documentation or guide. Cloning is not really difficult.
There are basic problems too, a good guide is needed for increasing awareness.
As practically we are not shifting, there is time. -
Mark Rowatt Anderson
Two thumbs up – go for it!
-
Edward Caissie
It reads like a lot of great points above … and I am all for them, too. Any rebase / clone issues would be far outweighed by the eventual benefits this will bring.
-
Amy Hendrix (sabreuse)
+1 It’s really not a big deal to rebase now compared to not having a good history sometime later.
-
Tom Willmot
+1 Do it. We run everything with WordPress as submodule, would not be hard to re-clone.
-
aaronholbrook
+1, anything that would move us closer to using Git would be fantastic. Also not a big deal to re-clone if needed.
-
Chris Jean
Sounds like a bandaid that needs to be ripped off. Better now than later when even more people use it.
-
mojowill
I’d love to see a full move to GIT for everything on wporg!
-
Sam Parsons
I’m all for the update in order to improve the history and prepare for a possible move to git. I’m wondering whether you plan to send a little message (could it be automated?) to all those who have forked the repo on github?
https://github.com/WordPress/WordPress/network/members
That would be hugely helpful in communicating the upcoming changes in case those people don’t read this blog (perish the thought).
-
Mark Jaquith
GitHub removed their private messaging feature, so I’d have no automated way of notifying everyone. This doesn’t concern me so much as we don’t accept pull requests on GitHub, so it’s not like their forks are functional in that way. I also think a lot of people fork repos and never update it from the upstream again. So they probably wouldn’t notice. And it’s easy enough to destroy it and refork it.
What I was considering doing was putting a note on our project description on GitHub, for the next few months, providing a link to a post that explained what happened and how to resolve the divergent Git history.
-
-
Mark Jaquith
As the response was overwhelmingly positive (even from some of you who are traditionally serial devil’s advocates), I think we’re going to move forward with this. Thanks, all, for your feedback.
What I’ll likely do it consult with various people (@bpetty, notably) about implementation, doublecheck the e-mail address in my authors.txt file (recommending that everyone use addresses at personal domains that they’re likely to control indefinitely), and then push out a WordPress-Fixup repo for people to audit, before pushing the new history to the WordPress repo.
-
Bryan Petty
Confirming email addresses used would definitely be a good idea. I think a large portion of what you have now originally came from my list, which was meticulously put together from scouring plugin readmes, wp-hackers archives, and personal sites for publicly visible addresses since, at the time, I knew I wouldn’t be able to simply pull them from WP.org accounts used to make the commits (which would likely be the best source, aside from contacting everyone individually).
-
-
BFTrick
This sounds brilliant.
-
-
Mark Jaquith
WordPress 3.6: Distraction-Free Writing improvements
Distraction-Free Writing (DFW) made its debut in WordPress 3.2. It’s good, but it has some problems:
- It’s hard to discover. A tiny button that doesn’t stand out from other buttons.
- The transition is a bit jarring. Your content goes away, you land on another screen, and your content reappears. It feels like there is a cost to switching.
- It isn’t as fully-featured as it should be. If it isn’t capable of easily (and by that I, I mean without keyboard shortcuts) doing the majority of the formatting people need to do while writing, people are going to be disinclined to use it.
- It could use some polish. Some of the interactions are janky, and it’s not very responsive to large screens. There are strange issues that happen when you get to the end of a line or do a line break near the bottom of the editor. The Esc key doesn’t work when in TinyMCE. Lots of little stuff like that.
What I need is someone with CSS skills and JS competency to take on a bunch of little improvement projects for DFW. If you have those skills and care about making a beautiful and functional distraction-free writing experience for WordPress, speak up!
-
Chris Wallace
I’d like to help if you need me to.
-
Andy Stratton
I’m interested and would like to get an idea of the list fo things to be done (CSS/JS). I’ll probably try to get @bmoredrew to help me too – anything we have competency and time to do I’m interested.
-
bmoredrew
I’m down!
-
-
Jeff Bowen
I don’t have the bandwidth to lead this, but I’d love to pitch in
-
ckhicks
I’d be happy to help explore current/popular trends in DFW environments and provide research, if needed. This is one of my favorite WP 3+ features, and it is prime real estate for greatness!
-
Eric Mann
I’d love to help, though it would be useful if we had a concise list of all of the “janky” interactions so we know what we’re committing to.
-
Zach "The Z Man" Abernathy
I’m on board to help with this. And I agree with Eric Mann. A playbook on what we’re committing to would be great.
-
Mel Choyce
Not a terrible amount of js competency, but I’ve got css skills and would like to help out with this.
-
Slobodan Manic
Similar skillset and would love to help with this one.
There was probably talk about it already, but would moving full-screen button away from other buttons make sense? Perhaps next to Visual/Text tabs? Those two change the editor, so does full screen toggle.
-
-
theaccordance
I completely agree with your assessment. The moment I found that the DFW toolbar lacked the ability to select headings I walked away from the Distraction-Free view; this is certainly something I’d like to see an improvement with.
I just reviewed the full-screen views for a few apps on my Mac (which provide a similar experience to DF view), and with the exception of the top toolbar, the visual interactions remain fairly consistent. Would it be appropriate to approach the DF view in a similar fashion?
Also, should consideration be given in DFW for additional functionality added to the normal TinyMCE via plugins?
(Apologies if I should be bringing these questions up in a different location, I’m new and still getting acquainted with working on the core.)
-
adamsilverstein
i’m in.
-
John Blackbourn (johnbillion)
-
Mark Jaquith
As we have a lot of people willing to help, but none willing and confident to lead, and as this seems to be the least-well-defined of the features on the docket, it has been dropped as a scheduled feature and will instead be handled as the grab-bag of improvements that it is. I’ll work on getting it broken out into individual tasks and anyone interested should keep an eye out for “DFW” on Trac.
-
Robert Chapin (miqrogroove)
Hi Mark, a less prominent yet important disadvantage of DFW is the lack of cross platform compatibility. iPad and other device support ahould be considered.
Bryan Petty, 
I’ve just been a by-stander, but is there any way to let the Visual Editor display White text Lettering on a Dark Background instead of disappearing on the current White background when try to switch between dark and light themes.