Make WordPress Core

Updates from Lance Willett Toggle Comment Threads | Keyboard Shortcuts

  • Lance Willett 5:15 pm on May 9, 2013 Permalink | Log in to leave a Comment
    Tags: , ,   

    We’re getting very close This week focusing on… 

    We’re getting very close.

    This week focusing on RTL again, especially concerning :before and :after and Genericon placement, see #24287. Turns out we’ll need flipped versions of lots of the glyphs—which Joen is now working on. After Joen completes the Genericons font updates are ready we’ll sync them into Twenty Thirteen.

    Next is another quick pass at editor styles, including RTL support there.

     

  • Lance Willett 4:25 pm on April 23, 2013 Permalink
    Tags: , ,   

    Twenty Thirteen project update, April 23, 2013 

    The focus for Twenty Thirteen right now test, test, and test. Polish, polish, and polish. The IEs, RTL, testing with lots of popular plugins. Getting things working smoothly with the new core post formats functionality.

    Priorities

     

  • Lance Willett 6:37 pm on April 8, 2013 Permalink
    Tags: , ,   

    We love testers

    We’d love more people to install Twenty Thirteen, with special emphasis on trying out all the new Post Format features.

    Also, if you have access to Windows with various versions of Internet Explorer we especially need help testing out some IE8 and IE10 issues (see Trac list link below).

    Priorities

    • Address open tickets in Trac, fix bugs and make improvements
    • More browser, device, RTL, and i18n testing
    • Post formats testing. For example, looking at the output from post_formats_compat(), making suggestions like Image should use wp_get_attachment_image() there for filters and correct core class attribute values in the resulting HTML.
    • Review and possibly refactor the js/functions.js JavaScript file, going to all procedural/functional or moving to a new architecture—the key is to be consistent with it within the file. We can also look at namespacing the events.
    • Ask Joen to do another design audit, checking versus his design vision for things like spacing, colors, and post formats.

    Office hours

    We’ll get back to office hours in #wordpress-dev IRC over the next few weeks, Tue and Thu at 17 UTC.

     

    • celloexpressions 1:40 am on April 9, 2013 Permalink | Log in to Reply

      Can’t make it to the office hours, but want to point out a couple more IE 8 issues that may or may not be ticket-worthy. The headings are displaying in Georgia font, but Bitter should work for IE 8. It’s fine on 9 and 10.

      Also, the header image is zoomed in in IE 8. See both issues in these screenshots (emulating 8/9 with 10): http://celloexpressions.com/nh/twenty-thirteen-fonts-ie8.png, http://celloexpressions.com/nh/twenty-thirteen-fonts-ie9.png.

      By the way, is IE 7 supposed to be supported/should it be tested?

    • ziegenberg 3:00 pm on April 9, 2013 Permalink | Log in to Reply

      Here’s a WP 3.6 with (slightly altered – just colors) Twenty Thirteen. Working great so far!

      http://zubau.at

      • Lance Willett 9:53 pm on April 10, 2013 Permalink | Log in to Reply

        Thanks for the link—cool color scheme! I’m seeing a few bugs in the comment form layout, though. Will need to debug and fix soon.

    • lisafirke 2:20 pm on April 15, 2013 Permalink | Log in to Reply

      Love the brave new look of TwentyThirteen– I’m working on a child theme for my personal blog… (It’s live but on the QT so I’m not too worried about glitches at this point).

      A few issues I’ve seen… with the fixed navbar, the header image I hacked/inserted into the masthead overlays and hangs below the bar. I know I can turn this behavior off by commenting out the JS but it may be an example of a use case that your more dive-into-the-code users will encounter. (I wanted that image to scale, which is why I inserted it as I have…)

      Other notes: I couldn’t get the JetPack carousel to work with the gallery post format as it does on the demo. Not sure if I just missed a step or if it’s not hooked into the theme correctly.

      The Status post format looks odd with an image floated left on the post… I nixed the background dotted line, but the Genericon (or whatever is producing the horizontal bar glyph in place of the title) is kind of distracting, too.

      Here’s the link: http://lisafirke.com/blog

      Looking forward to rolling out the finished version with much fanfare…

      • Lance Willett 5:38 pm on April 15, 2013 Permalink | Log in to Reply

        Hi there, and thanks for your notes. The fixed navbar + inserted HTML image isn’t a bug we’ll fix in the core theme—that’s a great example of child themes adjusting and changing how the core theme works.

        We’ll investigate Jetpack Carousel and the Status post format left-aligned image a bit more.

        • Lance Willett 5:29 pm on April 16, 2013 Permalink | Log in to Reply

          Lisa: can you give more info on the Jetpack Carousel issues you had? I couldn’t repeat—seems to be working normally with all the various “types” of galleries in Jetpack.

          • lisafirke 9:12 pm on April 16, 2013 Permalink | Log in to Reply

            See my notes below. I think it’s a jquery/Jetpack glitch of some kind, because others are reporting similar issues with Jetpack.

            The main thing is, with Jetpack enabled, I’m still not seeing any formatting options for the carousel–I only have the ability to toggle from slideshow to grid on a gallery post.

            • Jeremy Herve 10:29 am on April 17, 2013 Permalink

              You’re probably right. We know of some conflicts between jQuery 1.9.1 and Jetpack Carousel, and we”ll get this fixed before 3.6 ships.

              See this ticket for more details about the conflict.

      • Lance Willett 4:40 pm on April 16, 2013 Permalink | Log in to Reply

        Hi again Lisa, to get rid of the horizontal bar glyph for Status posts, look for:

        .format-status .entry-content p:first-child:before

        And either change or comment it out in your child theme.

      • jrbeilke 5:28 pm on April 16, 2013 Permalink | Log in to Reply

        lisa was there a specific browser that you were having trouble with the JetPack carousel?

        I’ve got 3.6 beta on my blog and loaded up a carousel post with JetPack slideshow ok.

    • lisafirke 7:25 pm on April 16, 2013 Permalink | Log in to Reply

      I’m using Safari and the latest beta build. I fixed a javascript error that was preventing the slideshow from running, but I don’t see any way to enable a full-screen slideshow. Here’s my test post: http://lisafirke.com/blog/2013/carousel-test/

      • lisafirke 7:29 pm on April 16, 2013 Permalink | Log in to Reply

        I’m thinking the problem lies with Jetpack and not with TwentyThirteen?

        • lisafirke 8:18 pm on April 16, 2013 Permalink | Log in to Reply

          I disabled my test, so don’t bother clicking through. Only the background color and exif field data items are getting displayed as configuration options–and in the media ui no choice of carousels or any other configurables beyond “slideshow” versus “grid”.

    • Ipstenu (Mika Epstein) 8:02 pm on April 16, 2013 Permalink | Log in to Reply

      There are posts in Alpha/Beta about 2013 – http://wordpress.org/support/forum/alphabeta

      (look for the ones that aren’t resolved)

      • Lance Willett 8:55 pm on April 16, 2013 Permalink | Log in to Reply

        Thanks, triaged 3 of the unresolved ones (1 was not related to Thirteen specifically).

        • Ipstenu (Mika Epstein) 9:58 pm on April 16, 2013 Permalink | Log in to Reply

          Shirley :) Is there a good way to report them or flag them for you? I don’t know enough about what is and isn’t a theme decision (seriously, I hate debugging themes!) to feel comfortable raising tickets.

          Also if you’re not a forum mod, I’ll make you one so you can resolve those posts too ;)

    • Jeremy Herve 10:37 am on April 17, 2013 Permalink | Log in to Reply

      As discussed yesterday during office hours, I tested 2013 against Jetpack Trunk, and found 2 issues, that we will have to fix in Jetpack before 2013 is released.

      Infinite Scroll seems to work fine, whether you use footer widgets or not. All widgets seem to be displayed properly, although I haven’t tested in IE.

      No problems with post formats either. There were some conflicts between Jetpack Shortcodes and the new Audio shortcode, but it was fixed in r696694-plugins.

  • Lance Willett 9:09 pm on March 26, 2013 Permalink
    Tags: , ,   

    Twenty Thirteen project update, March 26, 2013 

    Our focus right now is on post formats integration, both structured (formats with post meta) and “normal” output for the other formats.

    Priorities

    1. Work with Post Formats team to get the_video(), the_audio(), and the_image() functions into core, so we can avoid a ton of extra logic in Twenty Thirteen’s functions.php file to grab the first asset for a format. Making it easier for *any* theme to get the same data back and keep their template files simpler. Themes should not have to parse shortcodes or try to make something run through oEmded before display.
    2. Work with Post Formats team on post_formats_compat() functionality, improving Quote markup and filling in the gaps for other formats. Obenland is going to work on a patch for this.
    3. Image: we need clarification from 3.6 leads and Post Formats team on whether it is going to be structured or not (post meta) and it needs more work for the post-media functions (see 1 and 2 priorities above)
    4. Finalize each post format in Twenty Thirteen: what template HTML or PHP it needs, what it needs from core functionality to work correctly

    By post format

    Here’s a breakdown per format, per today’s discussion (IRC log).

    • Standard: good to go
    • Aside: we remove the title from the PHP template, added styling; non-structured
    • Chat: IHNIWIGOWTPF (see IRC log, hehe); non-structured
    • Gallery: we use a bit of PHP to remove default gallery styles, and we use a filter to change the image size to large on index view, then add a bit of CSS fanciness to change the first image to “bigger” size, 300×300 (single view is not changed other than to align the columns); non-structured
    • Link: structured, we use get_the_url() wrapped in our own fallback to output permalink if no URL is found
    • Image: right now it works OK without any changes, but the design calls for the image to be above the title, which means we need a way to pull out the first image, and have the_content() be output without that image; also filter content_width to 724 for this format (small issue with that reported in #23863). Seems like the best approach here is to use a custom image size to grab an exact 724 px wide image (unless it’s smaller that 724, in which case we grab the largest available). Ideal: a user uploads an image, adds it to the post content at exactly 724 from the Media editor, then the_image() outputs the exact HTML img tag + attributes.
    • Quote: structured; currently we rely on people using blockquote correctly in the editor, and style it with CSS; after Obenland’s patch to Quote markup (noted above in priority 2) we’ll add CSS support for the structured HTML markup, and leave in the basic styles in case someone uses post content anyway
    • Status: similar to Aside
    • Video: structured; we filter content_width to 724 to allow the video to be wider than the rest of the content area; needs the_video() to return the HTML output of first video and remove the same from the post content
    • Audio: structured, we’re leaning towards using the post format compat output instead of a custom structure in the theme; needs more testing but seems to be working OK as-is right now
     

  • Lance Willett 7:32 pm on March 19, 2013 Permalink
    Tags: , ,   

    Twenty Thirteen project update, March 19, 2013 

    We’re in great shape to get to beta. Here is what we’re working on right now.

    Blocking older installs

    Tracked in #23819 — since Twenty Thirteen is 3.6+ only, older installs could see errors. We’d like to come up with a graceful way to not allow older versions of WordPress to install and run Twenty Thirteen.

    Maybe a nag function in the theme that puts up a warning? Forcing a change the previously activated theme upon activation? What are your thoughts?

    Relates to #13780 also.

    Post formats integration

    See #23619, #23620, and #23621 — we are waiting on the core functionality to be committed before we can change the theme code (images, videos, galleries, links).

    Recently completed

    • HTML5 improvements to comment list, comment form, and search form (yay!) #22005, #23702, and #23701
    • Solidify footer positioning when no JavaScript or no Masonry script available: #23771
    • More gallery visual fixes: #23773 and #23769

    Open issues

    Here is a link to open tickets.

     

    • Rami Yushuvaev 8:22 pm on March 19, 2013 Permalink | Log in to Reply

      Great work lance.

      But regarding to search forms, seems like you didn’t addressed the old discussions on tickets #14581, #19321, and #19579.

    • chp2009 10:49 pm on March 19, 2013 Permalink | Log in to Reply

      I think putting up a nag function that can only be seen by a user with admin permissions is a great idea. As a matter of fact only a user with admin permissions should be able to see errors related to the administration of the website. It creates a better user experience.

    • chacha102 5:04 am on March 23, 2013 Permalink | Log in to Reply

      Plugins can deactivated themselves if they know their requirements aren’t met. There needs to be a precedent set for how theme’s who requirements haven’t been met can ‘deactivate’ themselves.

      I think that the result of a theme ‘deactivating’ itself should cause the same result as if the theme suddenly was removed. I believe right now it defaults to the default theme in WordPress. I would argue doing anything different then that creates an inconsistent error scheme.

      • Myatu 11:19 am on March 23, 2013 Permalink | Log in to Reply

        If there was a way to track which theme it switched from (active before trying to activate this theme), then one could simply revert the action. That would be the safest method, as it does not alter the website in any way (ie., theme specific customizations, etc).

        • Myatu 11:25 am on March 23, 2013 Permalink | Log in to Reply

          Having that said… Why not include this sanity check within the WP core itself, for both plugins and themes. Just give add two extra meta headers to the plugins/themes for the minimum WP and PHP versions, and add a little extra code that checks against these prior to activation. That would be a useful feature that could benefit many. #thinkingoutloud

        • Lance Willett 7:31 pm on March 23, 2013 Permalink | Log in to Reply

          See #13780 for the WordPress version requirement support.

  • Lance Willett 10:12 pm on March 12, 2013 Permalink
    Tags: , ,   

    Twenty Thirteen project update, March 12 2013 

    This week we are closing as many open issues as possible to prepare for code freeze.

    Blockers

    Here are the current blockers to getting to a code freeze tomorrow, as scheduled:

    • Post formats: #23619 #23620 #23621 — waiting on the core functionality to be committed before we can change the theme code (images, videos, galleries, links)
    • #15080: Comment form HTML5 input types — just needs a commit
    • #20088: Improve wp_list_comments() markup — needs a code review from core team dev, then commit

    Recently finished

    Open issues

    Here is a link to all remaining open tickets.

     

    • RDall 10:22 pm on March 12, 2013 Permalink | Log in to Reply

      Oh my… I don’t think I have ever seen the default gallery so uber cool as I have in Twenty Thirteen…

  • Lance Willett 11:57 pm on March 4, 2013 Permalink
    Tags: , ,   

    Twenty Thirteen project update, March 4 2013 

    What we worked on last week

    Lots of fixes and improvements went in — thanks to everyone who reported and patched and tested.

    Bigger items discussed:

    1. Fixing the sidebar (including discussion of dropping it completely). We decided to just swap primary and secondary sidebars for now. See #23644.
    2. Remove fixed navbar for mobile — yes, let’s remove it. See #23647.
    3. Keep fixed navbar for desktop for now, but next step is to switch site title to menu there, try that out.

    IRC logs: Tue Feb 26 2013 | Thu Feb 28 2013

    What we’re doing this week

    More work on open tickets.

    Big items to tackle next:

    • Post format support: #23619 #23620 #23621
    • Sidebar / footer clearing, still no perfect CSS-only solution. JS techniques are next. See #23557.
    • Gallery styles: portrait sized images, #23649 — and caption styles, #23584.

    Non-theme tickets that affect Twenty Thirteen’s progress:

    • #15080: Comment Form Should use HTML5 input types for better accessibility
    • #15081: Search Form should use type=’search’
    • #20088: Improve wp_list_comments() comment markup

    Want to get involved?

    View open tickets.

    Join us in IRC during office hours and we can get you started on a ticket or task.

     

    • Monika 12:06 am on March 5, 2013 Permalink | Log in to Reply

      if a comment author is the post author his authorlink has “rel external and nofollow”,
      but his link is to the author page of the site, why rel external and why nofollow, no internal links should be nofollow,
      I ask this myself all the years ;)

    • RDall 5:05 am on March 5, 2013 Permalink | Log in to Reply

      I will try to get to the IRC during office hours… I just downloaded Twenty Thirteen Yesterday to my dev build. I am not a fan of the fixed nav bar… I understand I could make a child them to alter this… But it just looks odd… Take for example a 17in monitor without widgets. http://cl.ly/image/3K303B150131 I know I am late to the game… I know this has been previously discussed… Not asking to rehash something again… but just to give my “2cents” even if abet a bit late…

    • Maor Chasen 7:44 pm on March 7, 2013 Permalink | Log in to Reply

      Ha! The GIF on #23647 is a killer!

  • Lance Willett 6:58 pm on February 21, 2013 Permalink
    Tags: , ,   

    Twenty Thirteen project update 

    The Twenty Thirteen team jumped into 3.6 with two two first office hours this week; things are off to a great start. We’re meeting in #wordpress-dev IRC on Tuesdays and Thursdays at 17 UTC.

    Who we are

    (These are WP.org usernames.)

    • Leads: lancewillett and obenland
    • Contributors joining us for office hours this week: johnbillion kwight clakeb karmatosed sabreuse taupecat jorbin bpetty MikeHansenMe georgestephanis jayjdk nacin

    Many other folks already contributed patches and tickets, thank you.

    What we’re working on

    Tuesday we started by dividing things up a bit:

    • Color contrast and general accessibility (sabreuse and jorbin)
    • Mobile behavior, the navbar and menu need some work (obenland, johnbillion, and karmatosed)
    • Device testing (karmatosed)
    • General bug reporting and patches (everyone)

    We also looked at open tickets for Twenty Thirteen.

    Thursday we had a more open discussion style. Based on people grabbing tasks I’ve added a “point person” in bold after each — if you want to jump in look for “Unassigned” here and drop a comment or ping me in IRC.

    (More …)

     

  • Lance Willett 6:51 am on February 28, 2012 Permalink
    Tags: ,   

    We’re digging in full bore to get things done by freeze. #19978 is the primary ticket.

    Tasks that need to happen by Wed Feb 29:

    • Finish the styling (Drew)
    • CSS file cleanup (Lance)
    • RTL stylesheet
    • Editor stylesheet

    The last big missing piece for styling is post formats.

    Update Wed Feb 29: see my comment below.

     

    • Lance Willett 5:41 am on February 29, 2012 Permalink | Log in to Reply

      Update: Twenty Twelve is not going to make the cut for 3.4.

      The design isn’t quite finished, and we risk a rushed, incomplete product by forcing it in.

      We’ll continue working on it so it’ll be ready at the start of the 3.5 development cycle, and do a longer report soon on why it was delayed so we can prevent it from happening again.

  • Lance Willett 10:00 pm on February 20, 2012 Permalink
    Tags: ,   

    Team Update: Twenty Twelve 

    We are still plugging away at theme styles and related code changes. See the task list on our last update for the exact things we’re working on and who’s working on what.

    I’ll keep that list updated as we continue to crank on the theme. You can also follow along in the main Trac ticket: #19978.

    One thing that came up this week is a minor revamp to the default comment markup, see #20088 for notes and a patch. If those changes are approved we can delete a big chunk of code from Twenty Twelve’s functions file.

     

← Older posts

c
compose new post
j
next post/next comment
k
previous post/previous comment
r
reply
e
edit
o
show/hide comments
t
go to top
l
go to login
h
show/hide help
shift + esc
cancel