Menus Office Hours (Feb 7)

Welcome!

The WordPress coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. development team builds WordPress! Follow this site for general updates, status reports, and the occasional code debate. There’s lots of ways to contribute:

Found a bugbug A bug is an error or unexpected result. Performance improvements, code optimization, and are considered enhancements, not defects. After feature freeze, only bugs are dealt with, with regressions (adverse changes from the previous version) being the highest priority.? Create a ticket in the bug tracker.

Want to contribute? Get started quickly with tickets marked as good first bugs for new contributors or join a bug scrub. There’s more on the reports page, like patches needing testing, and on feature projects page.

Other questions? Here is a detailed handbook for contributors, complete with tutorials.

Here’s a recap of yesterdays office hours.

Work accomplished since last office hours

jkudish moved the theme location options to checkboxes for us to test
I added accordion styling to menu items (for testing)
We tested 2 new users with these changes (and they both performed the scenarios flawlessly)
DrewAPicture implemented locations in the ‘Selected menu’ drop down

Major items discussed

1) Theme locations continues to be our biggest design challenge. We discussed a bunch of options and decided to go with checkboxes for theme locations for now – while we continue to stew on alternative approaches.

2) We discussed having settings at the top or the bottom, and settled on them being on the bottom.

On the docket

Refactor accordion code (@lessbloat)
Re-assess CSSCSS Cascading Style Sheets. in latest patchpatch A special text file that describes changes to code, by identifying the files and lines which are added, removed, and altered. It may also be referred to as a diff. A patch can be applied to a codebase for testing. (currently 23119.28.1.diff), and move colors to colors.css (Looking for a volunteer here)
Browser compat testing (Looking for a volunteer here)
No JSJS JavaScript, a web scripting language typically executed in the browser. Often used for advanced user interfaces and behaviors. testing (Looking for a volunteer here)
Code review (Looking for volunteers here – hopefully from multiple people)
Commit what we’ve got

After that

Any additional accessibilityAccessibility Accessibility (commonly shortened to a11y) refers to the design of products, devices, services, or environments for people with disabilities. The concept of accessible design ensures both “direct access” (i.e. unassisted) and “indirect access” meaning compatibility with a person’s assistive technology (for example, computer screen readers). (https://en.wikipedia.org/wiki/Accessibility) work
Additional code refactoring
Am I missing anything?

p.s. @DrewAPicture, I added a title this time just for you. 😉

#3-6, #menus

Drew Jaynes (DrewAPicture) 5:57 pm on February 8, 2013

RE: title, “He can be taught!”

We also need to do an extensive round of RTL testing as well as completing docblocks for any new functions we’re introducing, @access private or not.

I can start on no-js testing this weekend.
- lessbloat 6:05 pm on February 8, 2013
  
  I did a round of RTl testing/fixing (I’m not sure I would call it extensive, but I think I caught most everything).
  
  I can start on no-js testing this weekend.
  
  Awesome! Thanks for that.
  - Drew Jaynes (DrewAPicture) 10:06 pm on February 8, 2013
    
    I also added more complete docblocks to new functions in 23119.28.2.diff
- Bob Gregor 1:19 pm on February 23, 2013
  
  I can help with browser testing. Are we covering ie7? Or just 8+?
sireneweb 4:50 pm on February 11, 2013

Hi, very nice 🙂
When you use Mega drop down menu, you can’t delete all children from main menu. It would be great if we can Expand/Collaspe main menu and delete all children sub menu from main menu
- lessbloat 6:14 pm on February 11, 2013
  
  I asked @jkudish to gather some data around avg number of menu items per menu for sites on WP.com. Out of 1000 random sites (with at least one menu added), here’s what the distribution looked like:
  
  Excluding the menus with zero items added, the average comes out to 5.
  
  So, based on this data, should we make some sort of expand/collaspe menu item functionality a part of coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress., or keep it in pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party territory?
  
  I think my preference would be to keep it as a plugin, but I’d love to hear everyones thoughts.
  - Joey Kudish 7:04 pm on February 11, 2013
    
    Just a small correction to the description above, it was 3000 sites, not 1000. A lot of them didn’t have any menus at all, which is why if you add up the above numbers you don’t get 3000 🙂
  - Joey Kudish 7:05 pm on February 11, 2013
    
    Also, I agree with @lessbloat, I think this is pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party territory.

Comments are closed.

Welcome!

Communication

Share this: