I notice a lot of themes passing the ‘e…

Welcome!

The WordPress coreCore Core is the set of software required to run WordPress. The Core Development Team builds WordPress. development team builds WordPress! Follow this site for general updates, status reports, and the occasional code debate. There’s lots of ways to contribute:

Found a bugbug A bug is an error or unexpected result. Performance improvements, code optimization, and are considered enhancements, not defects. After feature freeze, only bugs are dealt with, with regressions (adverse changes from the previous version) being the highest priority.? Create a ticket in the bug tracker.
Want to contribute? Get started quickly with tickets marked as good first bugs for new contributors or join a bug scrub. There’s more on the reports page, like patches needing testing, and on feature projects page.
Other questions? Here is a detailed handbook for contributors, complete with tutorials.

I notice a lot of themes passing the ‘edit_themes’ capability when registering their options pages with add_theme_page(). On multisitemultisite Used to describe a WordPress installation with a network of multiple blogs, grouped by sites. This installation type has shared users tables, and creates separate database tables for each blog (wp_posts becomes wp_0_posts). See also network, blog, site installs edit_themes is reserved for super admins (and if a site defines DISALLOW_FILE_MODS then not even super admins will have it). If you want regular admins to be able to see the options page, which you probably do, you need to use ‘switch_themes’ instead of ‘edit_themes’. Perhaps we need an ‘edit_theme_options’ type cap if we want to be discreet from switch_themes.

Andrew Nacin 2:50 pm on April 16, 2010

I’ve never been a fan of checking for switch_themes either. Some sites have a theme that shouldn’t be changed, but that doesn’t preclude modifications to it via options panels. I’m all for something like edit_theme_options.
- Ryan Boren 3:37 pm on April 16, 2010
  
  I went ahead and added edit_theme_options capability. We might want to use this instead of switch_themes for custom headerHeader The header of your site is typically the first thing people will experience. The masthead or header art located across the top of your page is part of the look and feel of your website. It can influence a visitor’s opinion about your content and you/ your organization’s brand. It may also look different on different screen sizes. and background and other things.
  - Peter Westwood 8:58 am on April 17, 2010
    
    I’m a big fan of this sort of finer grained control.
    Sounds like an excellent idea to move the custom headerHeader The header of your site is typically the first thing people will experience. The masthead or header art located across the top of your page is part of the look and feel of your website. It can influence a visitor’s opinion about your content and you/ your organization’s brand. It may also look different on different screen sizes. and background to this cap to.
  - Andrew Nacin 2:16 pm on April 17, 2010
    
    I agree. If someone else doesn’t beat me to it, I’ll switch over headerHeader The header of your site is typically the first thing people will experience. The masthead or header art located across the top of your page is part of the look and feel of your website. It can influence a visitor’s opinion about your content and you/ your organization’s brand. It may also look different on different screen sizes., background, and nav menus to the new cap. Widgets too, I’d say.
  - Andrew Nacin 5:21 am on May 7, 2010
    
    Started this in https://core.trac.wordpress.org/ticket/13290. Could use a review.
Pingback: Version 1.1.2 | Thirty Ten
Lee Doel 10:44 am on April 20, 2010

I like the idea of edit_theme_options then there is no grey area.
mark 11:01 am on July 8, 2010

What is the status of this? It looks like it would be the solution for this idea.
- Andrew Nacin 9:13 pm on July 8, 2010
  
  Implemented in #13290.

Comments are closed.

Welcome!

Communication

Share this: